[CI] Disable the API breakage check #647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we instead keep it but relax the rule. Be good to know when we're breaking the underscored library product? |
|
We don't even attempt to keep the underscored library's API stable, it's purely for experimentation with in-memory codegen. So I don't particularly care when we break its API. |
simonjbeaumont
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This package doesn't have any library products that would need to maintain API stability, so we don't need to run the CI.
We only have
_OpenAPIGeneratorCore, which is underscored and not expected to be API stable (so it can only be used using anexact: "..."constraint). But we don't want to fail CI when we change that API (right now it's introducing noise in: #627)Modifications
Disable API breakage check.
Result
Disabled that CI step.
Test Plan
N/A